[llvm] r293823 - [ValueTracking] remove a FIXME for something we don't want to do; NFC

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 14:27:34 PST 2017

Author: spatel
Date: Wed Feb  1 16:27:34 2017
New Revision: 293823

URL: http://llvm.org/viewvc/llvm-project?rev=293823&view=rev
[ValueTracking] remove a FIXME for something we don't want to do; NFC

The comment was added with:
...but there would be a cost to implement this and possibly no payoff.


Modified: llvm/trunk/lib/Analysis/ValueTracking.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/ValueTracking.cpp?rev=293823&r1=293822&r2=293823&view=diff
--- llvm/trunk/lib/Analysis/ValueTracking.cpp (original)
+++ llvm/trunk/lib/Analysis/ValueTracking.cpp Wed Feb  1 16:27:34 2017
@@ -797,10 +797,6 @@ static void computeKnownBitsFromAssume(c
   // FIXME: Publish a warning/remark that we have encountered UB or the compiler
   // is broken.
-  // FIXME: Implement a stronger version of "I give up" by invalidating/clearing
-  // the assumption cache. This should indicate that the cache is corrupted so
-  // future callers will not waste time repopulating it with faulty assumptions.
   if ((KnownZero & KnownOne) != 0) {

Modified: llvm/trunk/test/Transforms/InstSimplify/assume.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstSimplify/assume.ll?rev=293823&r1=293822&r2=293823&view=diff
--- llvm/trunk/test/Transforms/InstSimplify/assume.ll (original)
+++ llvm/trunk/test/Transforms/InstSimplify/assume.ll Wed Feb  1 16:27:34 2017
@@ -28,8 +28,7 @@ define i64 @PR31809() {
 ; Similar to above: there's no way to know which assumption is truthful,
 ; so just don't crash. The second icmp+assume gets processed later, so that
-; determines the return value. This can be improved by permanently invalidating
-; the cached assumptions for this function. 
+; determines the return value.
 define i8 @conflicting_assumptions(i8 %x) {
 ; CHECK-LABEL: @conflicting_assumptions(

More information about the llvm-commits mailing list