[PATCH] D29412: [Assembler] Always copy temp inline assembly string.
Renato Golin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 1 14:16:38 PST 2017
rengolin added inline comments.
Comment at: lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp:115
+ // Always copy the inline assembly string into the memory buffer to preserve
+ // it until after finalization.
+ Buffer = MemoryBuffer::getMemBufferCopy(Str, "<inline asm>");
`Str` is an argument, so guaranteed (on a single thread) to exist through the execution of this function, no?
Or is this about the `report_fatal_error` at the end, which could print garbage?
More information about the llvm-commits