[PATCH] D29418: [libFuzzer] Add features `windows` and `posix` for lit tests.

[Zachary Turner via llvm-commits]

lgtm

On Wed, Feb 1, 2017 at 1:30 PM Marcos Pividori via Phabricator <
reviews at reviews.llvm.org> wrote:

> mpividori created this revision.
> Herald added a subscriber: mgorny.
>
> I add 2 features: `posix` and `windows`.
> Sometimes we want some specific tests only for posix and we use:
>
>   REQUIRES: posix
>
> Sometimes we want some specific tests only for windows and we use:
>
>   REQUIRES: windows
>
>
> https://reviews.llvm.org/D29418
>
> Files:
>   lib/Fuzzer/test/CMakeLists.txt
>   lib/Fuzzer/test/lit.cfg
>   lib/Fuzzer/test/lit.site.cfg.in
>
>
> Index: lib/Fuzzer/test/lit.site.cfg.in
> ===================================================================
> --- lib/Fuzzer/test/lit.site.cfg.in
> +++ lib/Fuzzer/test/lit.site.cfg.in
> @@ -1,4 +1,5 @@
>  config.test_exec_root = "@CMAKE_CURRENT_BINARY_DIR@"
>  config.llvm_tools_dir = "@LLVM_TOOLS_DIR@"
>  config.has_lsan = True if @HAS_LSAN@ == 1 else False
> +config.is_posix = @LIBFUZZER_POSIX@
>  lit_config.load_config(config, "@CMAKE_CURRENT_SOURCE_DIR@/lit.cfg")
> Index: lib/Fuzzer/test/lit.cfg
> ===================================================================
> --- lib/Fuzzer/test/lit.cfg
> +++ lib/Fuzzer/test/lit.cfg
> @@ -20,6 +20,12 @@
>  else:
>    lit_config.note('lsan feature unavailable')
>
> +if sys.platform.startswith('win') or sys.platform.startswith('cygwin'):
> +  config.available_features.add('windows')
> +
> +if config.is_posix:
> +  config.available_features.add('posix')
> +
>  if sys.platform.startswith('linux'):
>    # Note the value of ``sys.platform`` is not consistent
>    # between python 2 and 3, hence the use of ``.startswith()``.
> Index: lib/Fuzzer/test/CMakeLists.txt
> ===================================================================
> --- lib/Fuzzer/test/CMakeLists.txt
> +++ lib/Fuzzer/test/CMakeLists.txt
> @@ -226,6 +226,10 @@
>  # Note this is done after declaring all tests so we can inform lit if any
> tests
>  # need to be disabled.
>
>  ###############################################################################
> +set(LIBFUZZER_POSIX 1)
> +if (MSVC)
> +  set(LIBFUZZER_POSIX 0)
> +endif()
>
>  configure_lit_site_cfg(
>    ${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.in
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170201/62fc348b/attachment.html>