[PATCH] D26722: [WebAssembly] Add skeleton MC support for the Wasm container format

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 12:55:53 PST 2017

rnk added a comment.

In in favor of landing this. I think with one more +1 you'll be good to go.

Comment at: lib/MC/MCWasmStreamer.cpp:188
+void MCWasmStreamer::BeginCOFFSymbolDef(const MCSymbol *Symbol) {
+  llvm_unreachable("Wasm doesn't support this directive");
We should sink all of these calls to unreachable into MCStreamer, and tweak the message to be something like:
  this directive only supported on COFF targets

Comment at: lib/MC/WasmObjectWriter.cpp:79
+  typedef std::map<const MCSectionWasm *, std::pair<uint64_t, uint64_t>>
+      SectionSizesTy;
seems unused



More information about the llvm-commits mailing list