[PATCH] D29382: [lsan] Respect default value of detect_leaks flag

[Kostya Serebryany via Phabricator via llvm-commits]

kcc added a comment.

>> since we would like to have LSan on by default on 64 bit arches and off on 32 bit ones.

Mmm. Do we? why not have it on by default even on 32-bit? 
I remember that I was opposed to even enabling it at all on 32-bit, but if we enable it, let's make the default the same as on 64-bit, to avoid more confusion). 
I assume that there are no false positives on 32-bit, only false negatives.



================
Comment at: test/asan/TestCases/Linux/leak.cc:3
 // REQUIRES: leak-detection
+// UNSUPPORTED: x86
 //
----------------
why?


Repository:
  rL LLVM

https://reviews.llvm.org/D29382