[PATCH] D29362: Return Error instead of bool from mergeTypeStreams().

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 11:31:32 PST 2017


zturner added inline comments.


================
Comment at: llvm/lib/DebugInfo/CodeView/TypeStreamMerger.cpp:62
+    // Otherwise it will raise a runtime error. So we do that here.
+    (void)static_cast<bool>(LastError);
   }
----------------
Shouldn't we do this in the destructor instead?


https://reviews.llvm.org/D29362





More information about the llvm-commits mailing list