[PATCH] D29374: [libFuzzer] cmd prompt doesn't expand wildcard.

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 10:50:47 PST 2017

zturner added a comment.

That's true, but it's also true that more windows incompatible tests could be introduced for many other reasons.  But that's what the bot is for (assuming we can get it turned on in time).  It should be easy to see that the bot is failing on Windows and then choose the most appropriate fix.  If the only hammer you have is a big one, then that's the one you're always going to use.  It would be a shame if the default behavior of everyone who doesn't work on Windows when they see a bot fail is to just go and add `REQUIRES: not-windows` without at least seeing if there's an easy fix (such as this one).  I'm worried that if we have `REQUIRES: not-windows` then it will just become commonplace to add it to every test going forward instead of taking a few extra minutes to find a way to write the test so that it works everywhere.


More information about the llvm-commits mailing list