[PATCH] D29392: [ELF] - Change value checks to checkUInt for R_386_8/R_386_PC8/R_386_16/R_386_PC16 relocations.

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 10:04:50 PST 2017


davide requested changes to this revision.
davide added a comment.
This revision now requires changes to proceed.

Sorry to say that, but this doesn't seem quite right to me. We should really understand why that check fails and not silencing it.
It could be anything from a linker bug (including, the broken check itself) from the assembler emitting a broken object (BTW, which assembler are you using?)


https://reviews.llvm.org/D29392





More information about the llvm-commits mailing list