[PATCH] D29020: [ARM] Change TCReturn to tBL if tailcall optimization fails.

Oliver Stannard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 09:29:57 PST 2017


olista01 accepted this revision.
olista01 added a comment.
This revision is now accepted and ready to land.

A few typos in the comment, otherwise LGTM.



================
Comment at: lib/Target/ARM/ARMSubtarget.cpp:205
+  // baseline, since the LDM/POP instruction on Thumb doesn't take LR.  This
+  // means if we need to reload LR, it takes an extra instructions, which
+  // outweighs the value of the tail call; but here we don't know yet whether LR
----------------
Typo: "an extra instructions"


================
Comment at: lib/Target/ARM/ARMSubtarget.cpp:207
+  // outweighs the value of the tail call; but here we don't know yet whether LR
+  // is going to be used. We generate generate the tail call here and turn it
+  // back into CALL/RET in emitEpilogue if LR is used.
----------------
Typo: generate generate


https://reviews.llvm.org/D29020





More information about the llvm-commits mailing list