[PATCH] D29374: [libFuzzer] cmd prompt doesn't expand wildcard.

Kostya Serebryany via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 09:18:42 PST 2017

kcc added a comment.

In https://reviews.llvm.org/D29374#663301, @mpividori wrote:

> @kcc as far as I understand, cmd prompt is the only shell in all Windows systems by default. So we can't use a different one.

Then we probably shouldn't use any. 
Some of the tests in compiler-rt have 'REQUIRES: shell'
Will the same thing help here (either to require a shell on windows, or just to disable the test)?

Using xargs complicates the test.
The next time someone on linux will add more shell-ism to the tests and we will be constantly chasing failures on windows.

> Instead, I think `sancov` implementation should be updated to expand wildcards in its parameters.

I hope you are kidding.


More information about the llvm-commits mailing list