[PATCH] D29374: [libFuzzer] cmd prompt doesn't expand wildcard.

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 31 23:31:31 PST 2017


Relying on gnu win utils is not ideal, but since this test already does it,
lgtm
On Tue, Jan 31, 2017 at 10:06 PM Marcos Pividori via Phabricator <
reviews at reviews.llvm.org> wrote:

> mpividori created this revision.
>
> The commands should expand the wildcards in Windows, the cmd prompt
> doesn't.
> Because of that `sancov` was not finding the needed file. To deal with
> this, I use `ls` and `xargs` from gnu win utils.
>
>
> https://reviews.llvm.org/D29374
>
> Files:
>   lib/Fuzzer/test/dump_coverage.test
>
>
> Index: lib/Fuzzer/test/dump_coverage.test
> ===================================================================
> --- lib/Fuzzer/test/dump_coverage.test
> +++ lib/Fuzzer/test/dump_coverage.test
> @@ -2,7 +2,7 @@
>  RUN: BUILD_DIR=$(pwd)
>  RUN: rm -rf $DIR && mkdir -p $DIR && cd $DIR
>  RUN: not $BUILD_DIR/LLVMFuzzer-NullDerefTest -dump_coverage=1 2>&1 |
> FileCheck %s
> -RUN: sancov -covered-functions *.sancov
> $BUILD_DIR/LLVMFuzzer-NullDerefTest | FileCheck %s --check-prefix=SANCOV
> +RUN: ls *.sancov | xargs sancov -covered-functions
> $BUILD_DIR/LLVMFuzzer-NullDerefTest* | FileCheck %s --check-prefix=SANCOV
>  RUN: $BUILD_DIR/LLVMFuzzer-DSOTest -dump_coverage=1 -runs=0 2>&1 |
> FileCheck %s --check-prefix=DSO
>  RUN: not $BUILD_DIR/LLVMFuzzer-NullDerefTest -dump_coverage=0 2>&1 |
> FileCheck %s --check-prefix=NOCOV
>  RUN: rm -rf $DIR
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170201/12c009c6/attachment.html>


More information about the llvm-commits mailing list