[PATCH] D29371: [libFuzzer] Properly check if we can use dumpbin .

Marcos Pividori via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 31 21:27:20 PST 2017


mpividori created this revision.

The flag "/sumary" is necessary, otherwise it returns a non-zero value.


https://reviews.llvm.org/D29371

Files:
  lib/Fuzzer/FuzzerUtilWindows.cpp


Index: lib/Fuzzer/FuzzerUtilWindows.cpp
===================================================================
--- lib/Fuzzer/FuzzerUtilWindows.cpp
+++ lib/Fuzzer/FuzzerUtilWindows.cpp
@@ -179,7 +179,7 @@
 }
 
 std::string DisassembleCmd(const std::string &FileName) {
-  if (ExecuteCommand("dumpbin > nul") == 0)
+  if (ExecuteCommand("dumpbin /summary > nul") == 0)
     return "dumpbin /disasm " + FileName;
   if (ExecuteCommand("llvm-objdump > nul") == 0)
     return "llvm-objdump -d " + FileName;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29371.86573.patch
Type: text/x-patch
Size: 501 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170201/36e41829/attachment.bin>


More information about the llvm-commits mailing list