[PATCH] D27586: AMDGPU/SI: Add llvm.amdgcn.s.buffer.load intrinsic

Marek Olšák via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 31 17:42:16 PST 2017

mareko added a comment.

In https://reviews.llvm.org/D27586#662432, @tstellarAMD wrote:

> In https://reviews.llvm.org/D27586#662394, @mareko wrote:
> > How is this different from using amdgcn.buffer.load if https://reviews.llvm.org/D28993 lands (which is not certain)?
> I don't think it's legal to select amdgcn.buffer.load to SMRD unless you can prove that it is uniform.  llvm.amdgcn.s.buffer.load is known to always be uniform.

Well, I can't prove that it is uniform, but neither does Mesa for non-constant offsets. The idea of my patch is that SMRD is selected first and moveToVALU will lower it if necessary.


More information about the llvm-commits mailing list