[PATCH] D29308: [PM] Hook the instrumented PGO machinery in the new PM
David Li via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 31 15:54:32 PST 2017
davidxl added inline comments.
Comment at: lib/Passes/PassBuilder.cpp:394
+ // In the old pass manager, this is a cl::opt. Should still this be one?
+ IP.DefaultThreshold = 75;
can you refactor the old pm code such that the existing internal options can be reused here?
Comment at: lib/Passes/PassBuilder.cpp:487
+ // Indirect call promotion that promotes intra-module targes only.
this seems like exposing a bug in old implementation as well. IndirectCallPromotion pass need not to be run profile-use is in effect. Otherwise it is a waste of compile time.
More information about the llvm-commits