[PATCH] D29354: SanitizerCoverage: Support sanitizer guard section on darwin

Kuba (Brecka) Mracek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 31 15:53:53 PST 2017

kubamracek added a comment.

Agree with @kcc, I don't think we need the prefix abstraction macro and we can just have strings with the full section/symbol name.  E.g. in AddressSanitizer.cpp we have:

  StringRef AddressSanitizerModule::getGlobalMetadataSection() const {
    switch (TargetTriple.getObjectFormat()) {
    case Triple::COFF:  return ".ASAN$GL";
    case Triple::ELF:   return "asan_globals";
    case Triple::MachO: return "__DATA,__asan_globals,regular";
    default: break;
    llvm_unreachable("unsupported object format");


More information about the llvm-commits mailing list