[llvm] r293230 - CMake is funky on detecting Intel 17 as GCC compatible.

Yichao Yu via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 31 14:56:00 PST 2017


> It was suggested that this should be merged to 4.0. What do you think?

Not an expert of the backport policy but this looks safe to me.

>
> On Thu, Jan 26, 2017 at 3:50 PM, Yichao Yu via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> Author: yuyichao
>> Date: Thu Jan 26 17:50:18 2017
>> New Revision: 293230
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=293230&view=rev
>> Log:
>> CMake is funky on detecting Intel 17 as GCC compatible.
>>
>> Summary: This adds a fallback in case that the Intel compiler is failed to be detected correctly.
>>
>> Reviewers: chapuni
>>
>> Reviewed By: chapuni
>>
>> Subscribers: llvm-commits, mgorny
>>
>> Differential Revision: https://reviews.llvm.org/D27610
>>
>> Modified:
>>     llvm/trunk/cmake/modules/DetermineGCCCompatible.cmake
>>
>> Modified: llvm/trunk/cmake/modules/DetermineGCCCompatible.cmake
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/DetermineGCCCompatible.cmake?rev=293230&r1=293229&r2=293230&view=diff
>> ==============================================================================
>> --- llvm/trunk/cmake/modules/DetermineGCCCompatible.cmake (original)
>> +++ llvm/trunk/cmake/modules/DetermineGCCCompatible.cmake Thu Jan 26 17:50:18 2017
>> @@ -7,5 +7,7 @@ if(NOT DEFINED LLVM_COMPILER_IS_GCC_COMP
>>      set(LLVM_COMPILER_IS_GCC_COMPATIBLE OFF)
>>    elseif( "${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang" )
>>      set(LLVM_COMPILER_IS_GCC_COMPATIBLE ON)
>> +  elseif( "${CMAKE_CXX_COMPILER_ID}" MATCHES "Intel" )
>> +    set(LLVM_COMPILER_IS_GCC_COMPATIBLE ON)
>>    endif()
>>  endif()
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list