[llvm] r293373 - This addresses LLDB bug 31699, which was caused by LLVM using static linking on Windows.

[Hans Wennborg via llvm-commits]

On Tue, Jan 31, 2017 at 12:05 AM, Vadim Chugunov <vadimcn at gmail.com> wrote:
> Thanks Hans!
>
> I've confirmed that the startup crash is now fixed.
>
> However, I don't see the UCRT dlls in the /bin directory.  They look like
> this: api-ms-win-crt-<component>.dll   Do you have the Windows 10 SDK
> installed on your build machine?

I now realize you said "CMake 3.6+ already supports app-local
deployment of UCRT dlls" but I only have CMake 3.5.

I tried upgrading to CMake 3.7 and re-buliding but that didn't help :-/

I think I have the SDK; at least I have a "v10.0A" dir in C:\Program
Files (x86)\Microsoft SDKs\Windows. Shouldn't cmake error out or
something if it can't find the files?

> Also, looks like you need to update the download url to
> LLVM-**5**.0.0-r293474-win32.exe

Fixed. Thanks for noticing!


> On Mon, Jan 30, 2017 at 7:01 PM, Hans Wennborg <hans at chromium.org> wrote:
>>
>> I've just built a new snapshot that includes this revision:
>> http://llvm.org/pre-releases/win-snapshots/LLVM-4.0.0-r293474-win32.exe
>>
>> Can you please verify that it works and includes the correct DLLs? And
>> does it help LLDB?
>>
>> When I install it, I see these in the bin\ directory:
>> msvcp140.dll
>> vcruntime140.dll
>>
>> Thanks for pushing this forward!
>>
>> Hans
>>
>>
>> On Fri, Jan 27, 2017 at 11:39 PM, Vadim Chugunov via llvm-commits
>> <llvm-commits at lists.llvm.org> wrote:
>> > Author: vadimcn
>> > Date: Sat Jan 28 01:39:52 2017
>> > New Revision: 293373
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=293373&view=rev
>> > Log:
>> > This addresses LLDB bug 31699, which was caused by LLVM using static
>> > linking on Windows.
>> >
>> > In order to make sure that LLVM continues to work on machines that do
>> > not have the Universal CRT yet,
>> > we'll need to ship a copy of UCRT in the Windows installation package.
>> > Fortunately, CMake 3.6+ already
>> > supports app-local deployment of UCRT dlls, we just need to turn this
>> > on.
>> >
>> > Differential Revision: https://reviews.llvm.org/D29146
>
>
>