[PATCH] D29345: [sanitizer] Fix test on Darwin failing after 293682
Marcos Pividori via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 31 13:22:48 PST 2017
mpividori added a comment.
In https://reviews.llvm.org/D29345#662104, @kubamracek wrote:
> This fails with
> === NOTE === If you see a mismatch below, please update sanitizer_interface.inc files.
> < __sanitizer_free_hook
> < __sanitizer_malloc_hook
> < __sanitizer_symbolize_code
> < __sanitizer_symbolize_data
> < __sanitizer_symbolize_demangle
> < __sanitizer_symbolize_flush
In linux: nm -g lib/clang/5.0.0/lib/linux/libclang_rt.asan-x86_64.so | grep malloc_hook , outputs:
So, it looks like it is omitted in Darwin. I guess nm is ignoring weak symbols that doesn't provide a default implementation.
I can modify the tests to ignore weak symbols, and only check non-weak symbols, as the original test.
More information about the llvm-commits