[PATCH] D29336: [InstCombine] treat i1 as a special type in shouldChangeType()

Björn Steinbrink via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 31 13:07:25 PST 2017

dotdash added a comment.

LGTM except for the style nitpick which is just personal preference. I don't think I'm allowed to actually accept patches though.

Comment at: lib/Transforms/InstCombine/InstructionCombining.cpp:98
+  bool FromLegal = FromWidth == 1 ? true : DL.isLegalInteger(FromWidth);
+  bool ToLegal = ToWidth == 1 ? true : DL.isLegalInteger(ToWidth);
I think those would be a bit more legible when written as:

    bool ToLegal = ToWidth == 1 || DL.isLegalInteger(ToWidth)


More information about the llvm-commits mailing list