[PATCH] D29276: [ELF] - Linkerscript: do not fail on additional semicolons in linkerscript.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 31 12:48:06 PST 2017

ruiu added inline comments.

Comment at: lld/trunk/ELF/LinkerScript.cpp:1497-1498
+    if (Tok == ";") {
+      // Commands may contain excessive additional semicolons around.
+      // We should be able to parse it.
+    } else if (SymbolAssignment *Assignment = readProvideOrAssignment(Tok)) {
This is indeed better, but I think a more natural description about the grammar is that empty commands are allowed.



More information about the llvm-commits mailing list