[PATCH] D29315: MCMacho: Allow __thread_ptr section after dwarf sections

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added inline comments.


================
Comment at: test/MC/MachO/ARM/no-tls-assert.ll:2
+; RUN: llc -filetype=obj -o /dev/null %s
+; This should not trigger the "Creating regular section after DWARF" assert.
+target triple = "thumbv7-apple-ios9.0.0"
----------------
grosbach wrote:
> MatzeB wrote:
> > aprantl wrote:
> > > It would be better to check the ASM output for the section switch commands. Otherwise this test succeeds even if llc is symlinked to /bin/true ;-)
> > The assert would not trigger when writing assembly, but I can probably pipe the output through llvm-objdump.
> That's concerning. What is the assembler doing differently? Any output from the object emitter directly from the compiler should be reproducible when going through assembly.
The assert is only in MCMachoStreamer. I assume when writing an assembly file the order in which we see the `.section` directives doesn't influence the order of the sections in the object file? That would explain why we wouldn't need to enforce the order for assembly.


Repository:
  rL LLVM

https://reviews.llvm.org/D29315