[PATCH] D29313: InterleaveAccessPass: Avoid constructing invalid shuffle masks

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 31 10:35:56 PST 2017

MatzeB added a comment.

In https://reviews.llvm.org/D29313#661751, @mssimpso wrote:

> Hi Matthias,
> This looks good to me. Nice find!
> I think in the past there may have been some effort made to keep the ARM and AArch64 tests in sync, but having just scrutinized all the existing tests, I know this is not strictly the case anymore. So feel free to add an identical test for AArch64 if you like, but I don't think it's necessary.

Thanks for the review. I've added the equivalent aarch64 test as well though it probably won't buy us anything as the bug was in the generic/common code.



More information about the llvm-commits mailing list