[PATCH] D29315: MCMacho: Allow __thread_ptr section after dwarf sections

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 31 09:58:01 PST 2017

aprantl added a comment.

That means the location of the __thread_ptr section can't affect relaxations in the code or have any similar such effects?
If that is the case, this LGTM.

Comment at: test/MC/MachO/ARM/no-tls-assert.ll:2
+; RUN: llc -filetype=obj -o /dev/null %s
+; This should not trigger the "Creating regular section after DWARF" assert.
+target triple = "thumbv7-apple-ios9.0.0"
It would be better to check the ASM output for the section switch commands. Otherwise this test succeeds even if llc is symlinked to /bin/true ;-)



More information about the llvm-commits mailing list