[llvm] r292188 - [TLI] Add prototype checking for all remaining LibFuncs.
Hans Wennborg via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 31 09:20:35 PST 2017
On Mon, Jan 30, 2017 at 12:48 PM, Friedman, Eli <efriedma at codeaurora.org> wrote:
> On 1/27/2017 7:16 PM, Ahmed Bougacha wrote:
>> Hey folks,
>> I'm pondering whether to merge this to 4.0. It's not a small change,
>> but it's hopefully only making existing functionality stricter.
>> It fixes a handful of issues, some introduced by r267758 (in 3.9),
>> some of which can be exposed in C code (using invalid libc protos; I
>> could probably reduce the patch to the funcs I know of?).
>> Does that sound desirable? Thanks!
> The argument in favor is that this is a bugfix for an issue which could
> result in weird crashes or miscompiles. The argument against is that this
> is a large patch, the issue isn't a regression from 3.9, the problem doesn't
> reproduce with well-formed code, and this problem hasn't shown up in
> real-world code. (Feel free to correct me if one of those statements is
> Given that, I don't think I would suggest merging this to 4.0.
I'm inclined to agree with Eli. The change seems good, but not urgent
enough to merge.
More information about the llvm-commits