[PATCH] D27415: [ELF] - Replace MergeOutputSection with synthetic input section MergeSection.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 31 02:09:47 PST 2017

>I have spent some time simplifying the patch. It is attached and I
>think it is substantially simpler than the previous version.

Thanks  a for your time, your version looks better.
Will you commit then ?

>It can be made simpler still by removing a few hacks to set EntSize
>and SHF_MERGE on the output flags. I suggest making that in a followup
>patch so as to not change too many tests at once.

Yes, I also set EntSize in my version to avoid changing testcase in currect patch.
I can prepare such patch after landing this.

>This patch should also enable some simplifications in the linker script code.
>George, would this work for you? I included a simplified version of
>the testcase you mentioned.

Seems works perfectly, I checked reproduce I had for videocard symbols and they have different values now.
Adds a big chance for kernel to boot I suppose :) 

Thanks again.


More information about the llvm-commits mailing list