[PATCH] D29273: [ELF] - Added partial support for --emit-relocs (no --gc-section case)

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 31 01:25:33 PST 2017


>> Index: test/ELF/emit-relocs-gc.s
>> ===================================================================
>> --- test/ELF/emit-relocs-gc.s
>> +++ test/ELF/emit-relocs-gc.s
>> @@ -0,0 +1,5 @@
>> +# REQUIRES: x86
>> +# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t1.o
>> +# RUN: not ld.lld --gc-sections --emit-relocs %t1.o -o %t 2>&1 \
>> +# RUN:    | FileCheck -check-prefix=ERR %s
>> +# ERR: --emit-relocs and --gc-sections may not be used together
>
>This is for the next patch, no?

What exactly ? I think we should check and error out that combination,
since it works incorrectly in this patch (because not implemented).

I can move this check to another testcase if you want, though
I see nothing bad to have it in separate test which 
explicitly restricts that combination atm.

George.


More information about the llvm-commits mailing list