[PATCH] D29299: [X86][Tablegen] Fixing register defs and uses for the ENTER instruction.

[Chris Ray via Phabricator via llvm-commits]

cray added inline comments.


================
Comment at: lib/Target/X86/X86InstrInfo.td:1080
 // Constructing a stack frame.
-def ENTER : Ii16<0xC8, RawFrmImm8, (outs), (ins i16imm:$len, i8imm:$lvl),
-                 "enter\t$len, $lvl", [], IIC_ENTER>, Sched<[WriteMicrocoded]>;
+let Defs = [EBP, ESP], Uses = [EBP, ESP], mayLoad = 1, hasSideEffects=0 in
+def ENTER    : Ii16<0xC8, RawFrmImm8, (outs), (ins i16imm:$len, i8imm:$lvl),
----------------
craig.topper wrote:
> Why mayLoad? Shouldn't it be mayStore?
Nice catch!  I will fix this.


Repository:
  rL LLVM

https://reviews.llvm.org/D29299