[PATCH] D29311: [LoopUnroll] Use addClonedBlockToLoopInfo to add loop header to LI (NFC).

Michael Kuperstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 30 15:37:34 PST 2017

mkuper accepted this revision.
mkuper added a comment.
This revision is now accepted and ready to land.

Yeah, I think it's the same deal as https://reviews.llvm.org/D29173. The only reservation I have is that this is an optimization, since you avoid a look-up. But that looks like a really minor win to me, and it's better to simplify the code.
So, LGTM, unless @mzolotukhin wants the optimization. :-)

As to general code sharing improvements within the unroller - sounds worthwhile to me.


More information about the llvm-commits mailing list