[PATCH] D28489: [CodeGen] Move MacroFusion to the target

Evandro Menezes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 30 15:10:58 PST 2017


evandro added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64MacroFusion.h:26-35
+class AArch64MacroFusion : public ScheduleDAGMutation {
+  const AArch64InstrInfo &TII;
+public:
+  AArch64MacroFusion(const AArch64InstrInfo &TII)
+    : TII(TII) {}
+
+  void apply(ScheduleDAGInstrs *DAGInstrs) override {
----------------
MatzeB wrote:
> This can stay private to the .cpp file where createMacroFusionDAGMutation() is defined and doesn't need to go into a header.
> 
> The same comment applies to the X86 version.
You mean moving the method `scheduleAdjacent()` from `<Target>InstrInfo` to `<Target>MacroFusion` as a private function?


Repository:
  rL LLVM

https://reviews.llvm.org/D28489





More information about the llvm-commits mailing list