[PATCH] D29153: [BranchFolding] Tail common all identical unreachable blocks

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 30 15:07:50 PST 2017

rnk added inline comments.

Comment at: lib/CodeGen/BranchFolding.cpp:521
+static bool blockEndsInUnreachable(const MachineBasicBlock *MBB) {
+  return MBB->succ_empty() && !MBB->isReturnBlock();
iteratee wrote:
> Unforturnately there are platforms where this isn't sufficient. I believe ARM is one of them.
For all the ARM examples I constructed, isReturnBlock appeared to be accurate.


More information about the llvm-commits mailing list