[PATCH] D29306: Expose isLegalToPromot as a global helper function so that SamplePGO pass can call it for legality check.

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 30 14:29:20 PST 2017

davidxl added inline comments.

Comment at: lib/Transforms/Instrumentation/IndirectCallPromotion.cpp:149
     OK,                   // Should be able to promote.
     NotAvailableInModule, // Cannot find the target in current module.
Why keeping this one value but eliminating all the others?

Comment at: lib/Transforms/Instrumentation/IndirectCallPromotion.cpp:154
+  bool isPromotionLegal(Instruction *Inst, uint64_t Target, Function *&F,
+                        const char **Reason=nullptr);
missing space


More information about the llvm-commits mailing list