[PATCH] D27415: [ELF] - Replace MergeOutputSection with synthetic input section MergeSection.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 30 11:50:36 PST 2017

George Rimar via Phabricator <reviews at reviews.llvm.org> writes:

>> I do not understand why we need to care about sh_entsize of our output files. Why can't you just leave it 0?
> Well, that is actually the question I wish to find answer and mentioned in description of patch.
> We set sh_entsize and checked it in testcases before, when each different mergeable section was a single output.
> If we can ignore it and set to 0, that makes patch a bit easier. Looking on gold output which is inconsistent,
> looks that value makes no sence (if not -r elocatable).

I don't think we need to set it other than for -r and would suggest just
using 0 for simplicity in all other cases.


More information about the llvm-commits mailing list