[PATCH] D28307: Add Instruction number to LSR cost model (PR23384) part 1 of 3

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 30 11:39:03 PST 2017

qcolombet added a comment.

Please merge the opt and llc test cases into one file.
Note: It would be nice to have two opt run lines per test case:

- one with lsr insns cost
- one without

That may help catch the difference between those two modes. E.g., have a common prefix BOTH and one WITH and one WITHOUT. If the difference between WITH and WITHOUT is too big (i.e., not that much BOTH prefix), don't bother.

Comment at: test/Transforms/LoopStrengthReduce/X86/lsr-insns-2a.ll:5
+; For x86 LSR should prefer complicated address to new lsr induction
+; variables.
You can set several run line with different check prefix in the same file.
I.e., do not duplicate the test input.

Could you check that we have the desired addressing pattern instead of not having an lsr generated variable?



More information about the llvm-commits mailing list