[PATCH] D27654: Stop intercepting mallinfo and mallopt on FreeBSD
Dimitry Andric via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 30 10:23:40 PST 2017
dim added a comment.
In https://reviews.llvm.org/D27654#660686, @rnk wrote:
> In https://reviews.llvm.org/D27654#660232, @dim wrote:
> > In https://reviews.llvm.org/D27654#660158, @timurrrr wrote:
> > > Also be careful if you proceed with removing the cfree wrapper as it may have unexpected consequences on Windows.
> > Interesting. Since I'm not that familiar with Windows development anymore, what kind of things could go wrong? If it's too much hassle I can simply undo the removal, and get rid of the cfree test for Windows.
> The implementation of winasan cfree just aborts. I'd delete it and see if the bots like it.
Yes, I did just that in the last update of this diff. I hope that nobody minds if I break the bots twice :)
More information about the llvm-commits