[PATCH] D29283: [ARM] Avoid using ARM instructions in Thumb mode

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 30 08:20:47 PST 2017

rengolin added a comment.

Small comment about tests, but otherwise, looks good.

I'm slightly worried that `SWP` is deprecated in v6 and v7 and even optional in v7VE.

Not for this patch, but I'm wondering if we could make the instruction itself v4/v5 and have an InstAlias for v6/v7 so that we only generate is for old arches but still supports assembly with it.

Makes sense?

Comment at: test/CodeGen/Thumb2/conditional-cdp.ll:1
+; RUN: llc < %s -show-mc-encoding | FileCheck %s
It seems we're also missing ldc/stc/mcr etc. in the Thumb2 dir.


More information about the llvm-commits mailing list