[PATCH] D29276: [ELF] - Linkerscript: do not fail on additional semicolons in linkerscript.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 30 05:58:21 PST 2017


jhenderson added subscribers: davidb, jhenderson.
jhenderson added inline comments.


================
Comment at: ELF/LinkerScript.cpp:1497
+    if (Tok == ";") {
+      // Commands may contain excessive additional semicolons around.
+      // We should be able to parse it.
----------------
Slight grammar issue here - I think this should say something like "Commands may be surrounded by unnecessary additional semicolons", or better yet something like "Unnecessary semicolons are permitted here, but should be ignored."


https://reviews.llvm.org/D29276





More information about the llvm-commits mailing list