[PATCH] D28152: Cortex-A57 scheduling model for ARM backend (AArch32)

[Andrew Zhogin via Phabricator via llvm-commits]

andrew.zhogin added a comment.

> @andrew.zhogin : I tried to measure the impact of this patch on performance on a Cortex-A57 system, but with this patch, testing in Thumb mode, the cmake-based test-suite runs fail early during the configuration step, with the following error:
> 
>   -- Check size of unsigned long - failed
>   CMake Error at /usr/share/cmake-3.5/Modules/TestBigEndian.cmake:51 (message):
>     no suitable type found
>   Call Stack (most recent call first):
>     CMakeLists.txt:115 (test_big_endian)
> 
> 
> This doesn't happen when testing in ARM mode, or when testing without your patch applied.
>  I tested on r292764.
>  Could you try and see if you could reproduce this?
>  The lnt runtest test-suite command line I used looks as follows:
> 
>   lnt runtest test-suite --sandbox SANDBOX --no-timestamp --test-suite /work/llvm-test-suite --benchmarking-only --cppflags '-O3 -DNDEBUG -mcpu=cortex-a57 -mthumb -fomit-frame-pointer ' --threads 1 --build-threads 6 --use-perf time --use-lit lit --exec-multisample 1 --only-test=SingleSource/Benchmarks --cmake-define 'CMAKE_C_FLAGS_RELEASE=""' --cmake-define 'CMAKE_CXX_FLAGS_RELEASE=""'

I have updated patch with full support of thumb instructions.
I'am not familiar with lit - such command just succeeded on my local computer (x86_64) and I wonder why? It runs tests at some VM or remotely?

**********

Testing Time: 264.70s

  Expected Passes    : 126

2017-01-30 13:11:51: submitting result to dummy instance


https://reviews.llvm.org/D28152