[PATCH] D29119: [ImplicitNullCheck] NFC isSuitableMemoryOp cleanup

Serguei Katkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 30 00:31:41 PST 2017

skatkov added a comment.

Will appload a new version soon. I'm ok with all comments.

Comment at: lib/CodeGen/ImplicitNullChecks.cpp:493
+      return false;
+    if ((SRResult == SR_OK) &&
         canHoistLoadInst(&MI, PointerReg, InstsSeenSoFar, NullSucc,
sanjoy wrote:
> The braces around `SRResult == SR_OK` is unnecessary.
To me it is more readable.


More information about the llvm-commits mailing list