[PATCH] D29243: Cache reverse graph edges during dominator construction to avoidhaving to look them up later.

[Davide Italiano via Phabricator via llvm-commits]

davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D29243#659650, @dberlin wrote:

> Mostly empirical testing. By far, most nodes are either unconditional jumps or two block conditionals (be cond, invoke, etc)


Makes sense. I would add a comment to explain, if you don't mind. Most of the times I scratch my head trying to figure out how `SmallVector<>` initial size was chosen, and guess what, sometimes the choice is quite arbitrary (here we have a rationale, so wouldn't hurt adding that to the code). Assuming your non-x86 testing doesn't reveal any problems, I'd say ship it.


https://reviews.llvm.org/D29243