[PATCH] D29247: [ArgPromote] Re-arrange the code in a more typical, logical way.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 28 01:17:10 PST 2017


chandlerc created this revision.
Herald added a subscriber: mcrosier.

This arranges the static helpers in an order where they are defined
prior to their use to avoid the need of forward declarations, and
collect the core pass components at the bottom below their helpers.

This also folds one trivial function into the pass itself. Factoring
this 'runImpl' was an attempt to help porting to the new pass manager,
however in my attempt to begin this port in earnest it turned out to not
be a substantial help. I think it will be easier to factor things
without it.

This is an NFC change and does a minimal amount of edits over all.
Subsequent NFC cleanups will normalize the formatting with clang-format
and improve the basic doxygen commenting.


https://reviews.llvm.org/D29247

Files:
  lib/Transforms/IPO/ArgumentPromotion.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29247.86172.patch
Type: text/x-patch
Size: 59504 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170128/0f764fb1/attachment.bin>


More information about the llvm-commits mailing list