[PATCH] D29211: InferAddressSpaces: Support memory intrinsics

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Transforms/Scalar/InferAddressSpaces.cpp:585
+                               MSI->getLength(), MSI->getAlignment(),
+                               false, TBAA, ScopeMD, NoAliasMD);
+    } else if (MemTransferInst *MTI = dyn_cast<MemTransferInst>(MI)) {
----------------
jlebar wrote:
> jlebar wrote:
> > Would you mind adding `/*foo=*/false` here and below?  See my now five-year-old screed, http://jlebar.com/2011/12/16/Boolean_parameters_to_API_functions_considered_harmful..html
> Not done?
Missed a spot, got the other 2


https://reviews.llvm.org/D29211