[PATCH] D25849: [GVN] Prevent load coercion with irregular vector types

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 27 18:40:10 PST 2017


dberlin added a comment.

I guess i disagree that it would pass our usual review standard.
Our usual review standard would have been to disable or revert the thing that added the ability to do this in the first place.
if that fails, we'd turn it off.
Failing that, we'd generally make targeted fixes like this one.

Your argument here seems to be "it doesn't fix enough".  Is there a testcase demonstrated for that?

also, if you see a larger trend, i totally thing that is worth bringing up on llvm-dev.
However, realize there's plenty of code there simply are no maintainers for.


https://reviews.llvm.org/D25849





More information about the llvm-commits mailing list