[PATCH] D28596: [compiler-rt] General definition for weak functions.

[Marcos Pividori via Phabricator via llvm-commits]

mpividori added a comment.

@alekseyshl Thanks for your feedback.

Yes, I agree about the `#ifdefs`. After this diff I only include `sanitizer_win_defs.h` in files including windows code, except `sanitizer_internal_def.h`, so I think I can simply use an "#ifdef" there.

I created 2 macros: `WIN_WEAK_IMPORT_DEF` and `WIN_WEAK_EXPORT_DEF` and I included their definition in `sanitizer_win_defs.h` because this simplifies the code in `sanitizer_internal_defs.h`. Otherwise, I would be including a lot of Windows specific comments there which make the code confusing.

Also, I need `WIN_WEAK_IMPORT_DEF` for other windows specific files, in the next diffs.


https://reviews.llvm.org/D28596