[PATCH] D28675: [DAGCombine] require UnsafeFPMath for re-association of addition

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 27 12:20:14 PST 2017


hfinkel added a comment.

In https://reviews.llvm.org/D28675#659056, @hfinkel wrote:

> In https://reviews.llvm.org/D28675#659055, @nhaehnle wrote:
>
> > > But you can't because they'll crash [...]
> >
> > That's what the hunk in SelectionDAG.cpp is about.
>
>
> OIC, alright. I recommend that, if you want this to go into the branch, we do a targeted fix and then expand on that in follow-up.


OTOH, maybe it is safer this way. Hrmm.

> 
> 
>> And d'oh on the SDValue thing, I'll fix that.




https://reviews.llvm.org/D28675





More information about the llvm-commits mailing list