[PATCH] D27169: [x86] Fix getAddressFromInstr

[Michael LeMay via Phabricator via llvm-commits]

mlemay-intel added inline comments.


================
Comment at: lib/Target/X86/X86InstrBuilder.h:112
   const MachineOperand &Op3 = MI->getOperand(Operand + 3);
-  if (Op3.isGlobal())
+  // FIXME: Handle additional types of memory references below.
+  if (Op3.isGlobal()) {
----------------
qcolombet wrote:
> Could you describe what is missing?
I'm not familiar with all of the different types of memory operands, but I'm concerned that additional types may not be handled properly here given this issue with handling global address operands.  Just to pick one more example, perhaps external symbol operands need special handling, but I'm not sure.  Maybe I should revise my comment to "FIXME: Special handling may be required for additional types of operands below."


https://reviews.llvm.org/D27169