[PATCH] D28571: RuntimeDyldELF/AArch64: Implement basic support for PIC relocations

Eugene Leviant via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 27 02:23:11 PST 2017


evgeny777 added a comment.

Thanks for looking at it. I'll wait a few days in case someone jumps in.



================
Comment at: test/ExecutionEngine/RuntimeDyld/AArch64/ELF_ARM64_PIC_relocations.s:24
+
+## Test that .got section has two entries pointing to f, g and _s
+# *{8}section_addr(pic-reloc.o, .got) = f
----------------
peter.smith wrote:
> do you mean "three entries pointing to f, g, and _s"?
Yep. Will fix in final commit


https://reviews.llvm.org/D28571





More information about the llvm-commits mailing list