[PATCH] D29127: [ARM] Classification Improvements to ARM Sched-Model. NFCI.

Diana Picus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 27 01:35:19 PST 2017


rovka added inline comments.


================
Comment at: lib/Target/ARM/ARMInstrInfo.td:4079
+           Requires<[IsARM, HasV5TE]>,
+           Sched<[WriteMUL32, ReadMUL, ReadMUL]>;
 
----------------
I see you're modelling IIC_iMUL16 the same as IIC_iMUL32, but they don't seem to be exactly identical in any of the models (A9, A8, V6).  Same for IIC_iMAC16.


================
Comment at: test/CodeGen/ARM/misched-int-basic.ll:41
+  %conv = sext i32 %add2 to i64
+  %mul3 = mul nsw i64 %conv, %conv
+  ret i64 %mul3
----------------
Can you also add a test for 64-bit mac?


https://reviews.llvm.org/D29127





More information about the llvm-commits mailing list