[PATCH] D29165: NVPTX: Trivial cleanups of NVPTXInferAddressSpaces

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/NVPTX/NVPTXInferAddressSpaces.cpp:472
     // address spaces of its operands.
-    DEBUG(dbgs() << "Updating the address space of\n"
-                 << "  " << *V << "\n");
+    DEBUG(dbgs() << "Updating the address space of\n  " << *V << '\n');
     Optional<unsigned> NewAS = updateAddressSpace(*V, *InferredAddrSpace);
----------------
jlebar wrote:
> arsenm wrote:
> > jlebar wrote:
> > > I don't really care, but I have to admit that I find '\n' in place of "\n" kind of a strange change to make.
> > I think it looks nicer and allegedly this saves a call by using the more inlinable char version of <<
> I mean, presumably we are not optimizing for the speed of these dbgs() calls.
> 
> If my grep'ing is correct, *nobody* is doing '\n', so maybe we shouldn't make this change.
> 
> $ git grep 'dbgs().*"\\n"' | wc -l
> 1009
> $ git grep "dbgs().*'\\n'" | wc -l
> 0
I've been consistently using single quote chars in AMDGPU so something is probably off


https://reviews.llvm.org/D29165