[PATCH] D28937: AMDGPU: Treat 0 as private null pointer in addrspacecast lowering

[Tony Tye via Phabricator via llvm-commits]

tony-tye added inline comments.


================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:2170
   SDValue Src = ASC->getOperand(0);
-
-  // FIXME: Really support non-0 null pointers.
-  SDValue SegmentNullPtr = DAG.getConstant(-1, SL, MVT::i32);
   SDValue FlatNullPtr = DAG.getConstant(0, SL, MVT::i64);
 
----------------
Should this also use the new getSegmentNullPtrValue?


https://reviews.llvm.org/D28937