[PATCH] D28908: [Compiler-rt] Broken compiler-rt CMake configuring on Windows

Oleg Ranevskyy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 26 10:26:05 PST 2017


iid_iunknown added a comment.

In https://reviews.llvm.org/D28908#656573, @mgorny wrote:

> Well, it doesn't seem to break anything for me on Linux and it resembles the code below, so I guess it's good to go.


Yes, the patch just guarantees that the path is in the proper format for cmake, and leaves the path untouched if it is ok (which is currently the case for any non-Windows platform).

Thanks for reviewing this!


Repository:
  rL LLVM

https://reviews.llvm.org/D28908





More information about the llvm-commits mailing list